Decypher file attribute in a FOR loop

I am running a .bat file using the "for" command to run through files in a directory.  I am retrieving the file name and date created through the appropriate variables.  If the file is over a certain age I delete it.  I want to add code to check if the file has been archived.  I added the variable to get the file attribute.  However, I am having trouble decyphering the format.  Can someone help me out here???  Here is the "for" command:


for /r C:\Work\File %%a in ("*.*") do call :delfile %%~sa %%~ta %%~aa


Thanks,
Ken

For %~a recognizes 9 attributes. In the 9 character string returned, if a particular attribute is present, the character in the corresponding position is shown. if the attribute is absent, then a dash is shown.

For example, if the archive bit is set, then the third character is 'a', if it is unset, then the third character is '-'.

Code: [Select]

Directory        d--------
Readonly         -r-------
Archive          --a------
Hidden           ---h-----
System           ----s----
Compressed       -----c---
Offline          ------o--
Temporary        -------t-
Reparse_Point    --------l


Hello

@OP, ignore bill as he is trolling. Follow Salmon's method and you should be fine

@OP, ignore bill as he is trolling. Follow Salmon's method and you should be fine

What is delfile?

A Label in the batch file that the OP has taken the excerpt from.

Here is more of the code.  The delfile is a label to the body of the code.  Any way that I attempt to check the contents of %5 I get an error.  I am not a DOS expert.  I know enough to be dangerous but not effective!!


for /r C:\Work\File %%a in ("*.*") do call :delfile %%~sa %%~ta %%~aa

goto :end


:delfile %1 %2 %3 %4 %5

echo %1
echo %2
echo %3
echo %4
echo %5

if %5:~2,1% EQU "a"

(a)

:delfile is only seeing 4 passed parameters, so your attempt to process the 5th is causing an error.

they are:

1. %%~sa short file name of file which %%a expands to.

%%~ta expands to date [space] time stamp of %%a, so:

2. date part of %%~ta
3. time part of %%~ta

and finally

4. %%~aa attributes of %%a

(b)

%5 is a passed parameter. You cannot just tack another % sign on the end and treat it like an ordinary variable.

%4 contains the AM/PM part of the time. 

I attempted to set variable fattr to %5.  When I echo that variable there is no value in it.  Here is the output.



C:\Work\File Purge>for /R C:\Work\File %a in ("*.*") do call :delfile %~sa %~ta %~aa

C:\Work\File Purge>call :delfile C:\Work\File\AIMS_I~1.TXT 02/18/2008 02:36 PM --a------

C:\Work\File Purge>echo 1 = C:\Work\File\AIMS_I~1.TXT
1 = C:\Work\File\AIMS_I~1.TXT

C:\Work\File Purge>echo 2 = 02/18/2008
2 = 02/18/2008

C:\Work\File Purge>echo 3 = 02:36
3 = 02:36

C:\Work\File Purge>echo 4 = PM
4 = PM

C:\Work\File Purge>echo 5 = --a------
5 = --a------

C:\Work\File Purge>set fattr = --a------

C:\Work\File Purge>echo 
ECHO is on.

Oh so you are using US time format so I was wrong about the date & time (I am in a locale that use 24 hour time format)

Anyhow

don't use spaces in SET statements.

set fattr=%5

and, you don't need the parameter list after the subroutine label

:delfile %1 %2 %3 %4 %5

OK, I got it working. 

Thanks for your help! 


Ken

don't use spaces in SET statements.

That was a bit hasty; you must not put a space after the variable name, before the equals sign; you can put a space or spaces after the equals sign. But it or they will be part of the string assigned to the variable.

Code: [Select]

set variable =value
            ^
            |
            ^
 This space is an error; %variable% will be empty
 
 set variable= value
              ^
              |
              ^

 This space is allowed; it results
 in the string held in %variable% having a leading space

Hello

Well, there is nothing secret about what I am doing.  Here ya go.



for /r C:\Work\File %%a in ("*.*") do call :delfile %%~sa %%~ta %%~aa

goto :end


:delfile

echo 1 = %1
echo 2 = %2
echo 3 = %3
echo 4 = %4
echo 5 = %5

set fattr=%5

echo %fattr:~2,1%

if %fattr:~2,1% == a goto :end


set fdate=%2

set fdate
 
set mm=%fdate:~0,2%
set dd=%fdate:~3,2%
set yy=%fdate:~6,4%

set /a jd2=%yy%*1000

if %mm% GTR 01 set /a jd2=%jd2%+31
if %mm% GTR 02 set /a jd2=%jd2%+28
if %mm% GTR 03 set /a jd2=%jd2%+31
if %mm% GTR 04 set /a jd2=%jd2%+30
if %mm% GTR 05 set /a jd2=%jd2%+31
if %mm% GTR 06 set /a jd2=%jd2%+30
if %mm% GTR 07 set /a jd2=%jd2%+31
if %mm% GTR 08 set /a jd2=%jd2%+31
if %mm% GTR 09 set /a jd2=%jd2%+30
if %mm% GTR 10 set /a jd2=%jd2%+31
if %mm% GTR 11 set /a jd2=%jd2%+30
if %mm% GTR 12 set /a jd2=%jd2%+31

set /a jd2=%jd2%+%dd%

for /f "tokens=1-3 delims=/- " %%a in ('date /t') do (
set mm=%%a
set dd=%%b
set yy=%%c
)

set /a jd1=%yy%*1000

if %mm% GTR 01 set /a jd1=%jd1%+31
if %mm% GTR 02 set /a jd1=%jd1%+28
if %mm% GTR 03 set /a jd1=%jd1%+31
if %mm% GTR 04 set /a jd1=%jd1%+30
if %mm% GTR 05 set /a jd1=%jd1%+31
if %mm% GTR 06 set /a jd1=%jd1%+30
if %mm% GTR 07 set /a jd1=%jd1%+31
if %mm% GTR 08 set /a jd1=%jd1%+31
if %mm% GTR 09 set /a jd1=%jd1%+30
if %mm% GTR 10 set /a jd1=%jd1%+31
if %mm% GTR 11 set /a jd1=%jd1%+30
if %mm% GTR 12 set /a jd1=%jd1%+31

set /a jd1=%jd1%+%dd%

if %mm% EQU 01 (
if %dd% GEQ 06 (
set /a jd1=%jd1%-8
)
)

if %mm% GTR 01 (
set /a jd1=%jd1%-8
)

if %jd2% LSS %jd1% (
echo delete file %1
del %1
)

:end

Code: [Select]

if %fattr:~2,1% == a goto :end
That won't work. Lose the spaces around the equals signs, and also quotes are usual

This will

Code: [Select]

if "%fattr:~2,1%"=="a" goto :end
what's the logic of these lines

Code: [Select]

if %mm% GTR 01
etc?

is jd Julian date?

My tests on the attribute variable seemed to work but I will give your suggestion a try.

Code: [Select]

if %mm% GTR 01 set /a jd1=%jd1%+31
I am creating two dates in the format yyyyddd.  I start by taking the year and multiplying by 1000.  Then I have to add days based on the month.  If the month is March then I need to add the days for January and February.  Then I add the day for the date in question. 

For eample, suppose the date is 03/15/2009.  I take the year and multiply by 1000 getting 2009000.  The month is greater than 1 so I add 31 days for January.  The month is greater than 2 so I add 28 days for February (yes, I do not account for leap year).  The month is not greater than 3 so it falls through the rest of the "if" statements.  I then add the current day.  Now the date is 2009074.   

The "if" statement for greater than 12 will never be true and should be deleted.

I am creating two dates in the format yyyyddd.  I start by taking the year and multiplying by 1000

You may find these scripts useful

http://www.commandline.co.uk/cmdfuncs/dandt/index.html

Also, VBscript has built in date math functions. You can use them from batch, if VBscripts are allowed on your system

Code: [Select]

@echo off

REM Create VBscript
echo wsh.echo Year(wscript.arguments(0))^&DatePart("y", wscript.arguments(0))>Daynumber.vbs

REM now you can use it in your script as many times as you want

set querydate1=20/11/2009

REM pass the date to the VBscript & get back the result
for /f "delims==" %%D in ('cscript //nologo Daynumber.vbs %querydate1%') do set Daynumber1=%%D

set querydate2=20/03/2009

for /f "delims==" %%D in ('cscript //nologo Daynumber.vbs %querydate2%') do set Daynumber2=%%D

echo The day number of %querydate1% is %Daynumber1%
echo The day number of %querydate2% is %Daynumber2%

output

Code: [Select]

The day number of 20/11/2009 is 2009324
The day number of 20/03/2009 is 200979
As you can see, my system uses the European dd/mm/yyyy format for dates but I believe that if your system locale settings are US you would find that 11/19/2009 would give you 2009323 but you would have to try that yourself.

Hello