ERRORLEVEL = 0 within FOR loop

[ShadyDave]

I have posted previously about my DR check batch file, but just one issue remains...

I have this code within the batch...

example.txt contains the following line for testing...

\autoexec.bat

The for loop contains; - I changed the FIND to wwwwwwww to force a failure.

Code: [Select]

set TIB=example.txt
set SERVER=C:
for /f "eol=; tokens=* delims=" %%i in (%TIB%) do (
    dir "%SERVER%%%i" | find "wwwwwwww" >nul
    if %ERRORLEVEL%==0 (
        echo Located - %SERVER%%%i >> %logfile%
    ) else (
        echo ***ERROR*** - %SERVER%%%i, does not exist or incorrect file date >> %logfile%
    )
)

For some reason ERRORLEVEL always returns zero even if the file doesn't exist, I'm assuming that's because the FOR command didn't error even though the dir command did.
If I run the DIR command outside the FOR loop it returns errorlevel 1

Does anybody know of a way around this?

[BC_Programmer]

you can try

Code: [Select]

set TIB=example.txt
set SERVER=C:
for /f "eol=; tokens=* delims=" %%i in (%TIB%) do (
    dir "%SERVER%%%i" | find "wwwwwwww" >nul
    if ERRORLEVEL 1 (
        echo ***ERROR*** - %SERVER%%%i, does not exist or incorrect file date >> %logfile%
    ) else (
        echo Located - %SERVER%%%i >> %logfile%

    )
)

Or:
setlocal enabledelayedexpansion
set TIB=example.txt
set SERVER=C:
for /f "eol=; tokens=* delims=" %%i in (%TIB%) do (
    dir "%SERVER%%%i" | find "wwwwwwww" >nul
    if %ERRORLEVEL%==0 (
        echo Located - %SERVER%%%i >> %logfile%
    ) else (
        echo ***ERROR*** - %SERVER%%%i, does not exist or incorrect file date >> %logfile%
    )
)
endlocal

[Salmon Trout]

try this

variables set and read inside parenthetical expressions need delayed expansion.

setlocal enabledelayedexpansion
set TIB=example.txt
set SERVER=C:
for /f "eol=; tokens=* delims=" %%i in (%TIB%) do (
    dir "%SERVER%%%i" | find "wwwwwwww" >nul
    if !ERRORLEVEL! EQU 0 (
        echo Located - %SERVER%%%i >> %logfile%
    ) else (
        echo ***ERROR*** - %SERVER%%%i, does not exist or incorrect file date >> %logfile%
    )
)

[ShadyDave]

Thanks, not quite correct but you gave me a good pointer...

I just needed to replace % with !...

Code: [Select]

if !ERRORLEVEL!==0
setlocal command was already added but not included it in my post above 

I've noticed another issue, but I'll create a new post 

[Salmon Trout]

not quite correct

Code: [Select]

if !ERRORLEVEL!==0

Code: [Select]

if !ERRORLEVEL! EQU 0
These two are equivalent; I don't understand why you call my version "not quite correct".

[ShadyDave]

It created an error using the EQU for some reason :-(

[Helpmeh]

It created an error using the EQU for some reason :-(

What was the line?
If !ERRORLEVEL! EQU 0 echo There was no error...

should work properly.

[Salmon Trout]

What was the line?
If !ERRORLEVEL! EQU 0 echo There was no error...

should work properly.

It works properly for me.