GTR and LSS seem to fail for large sizes

[BeemerBiker]

Was trying to determine which ISOs are BluRay and which are DVD and I picked 9gb as the size cutoff.  %~z1 gave the correct size but GTR failed to calculate properly.  Maybe I did something wrong or perhaps there is another way to differentiate the two types.

echo %1 %~z1
@ECHO OFF
SET SIZELIMIT=9000000000
SET FILESIZE=%~z1

IF %FILESIZE% GTR %SIZELIMIT% Goto No

ECHO DVD
PAUSE
GOTO :EOF

:No
ECHO BluRay
PAUSE
GOTO :EOF

Thanks for looking.

[Squashman]

Correct.  Because batch files can only handle 32bit Integers.

[Squashman]

Change your IF comparison to use quotes.

Code: [Select]

IF "%FILESIZE%" GTR "%SIZELIMIT%" Goto No

[Salmon Trout]

@ECHO OFF
echo Wscript.echo eval(WScript.Arguments(0)) > evaluate.vbs
echo %1 %~z1
SET SIZELIMIT=9000000000
SET FILESIZE=%~z1
for /f "delims=" %%A in ('cscript evaluate.vbs "%filesize% > %sizelimit%"') do set result=%%A
If %result% equ -1 goto no
ECHO DVD
PAUSE
GOTO :EOF
:No
ECHO BluRay
PAUSE
GOTO :EOF

[BeemerBiker]

The suggestion to use quotes did not work.  Possibly only the first letter is checked.  However, Salmon's evaluate.vbs worked fine.  Sizeof or strlen would have worked OK if they existed.

[Squashman]

Well I tested it a few times with quotes and it worked. No it does not just compare the first character.

[BeemerBiker]

Strange - I tested it on both the Win10 command prompt and the Micro$oft VS 14 one and it appears only to check the first character.   Are you using the power shell or some other extension?

[Squashman]

You know you can copy and paste text from the cmd window.  Wouldn't that be a lot easier then posting a screen shot?

Strange - I tested it on both the Win10 command prompt and the Micro$oft VS 14

You realize there is no difference between the two?  You are just in a different directory.

[BC_Programmer]

As Squashman stated, it doesn't only compare the first character.

The confusion is in expecting a numeric comparison. The use of quotation marks makes it no longer a numeric comparison, instead, it is comparing the two values as strings.

Code: [Select]

if "2" lss "10" (echo lower) else (echo higher)
outputs "higher", becasue it is comparing the string "2" to the string "10" alphanumerically.

The "solution" is to have it use leading zeroes:

Code: [Select]

if "02" lss "10" (echo lower) else (echo higher)

outputs "lower".

using VBScript via evaluate.vbs tends to be the better alternative if you want to exceed the rather basic math capabilities of batch.

[Salmon Trout]

Sizeof or strlen would have worked OK if they existed.

@echo off
set mystring=9000000000
call :strlen %mystring%
echo string length %slen%
goto end

:strlen
set slen=0
set tempstring=%1
:loop
set tempstring=%tempstring:~0,-1%
set /a slen+=1
if "%tempstring%"=="" goto :eof
goto loop

:end
echo done
pause