only one instance of batch

[Salmon Trout]

Do you have tasklist.exe on your system?

[Blisk]

I have it. As far as I know all windows 7,8,10 have it.

[Blisk]

Any more ideas for this? 

[Geek-9pm]

Yes, you asked for one instance of batch and that is what  yu got.
Did you want something else?
If so, what?
You are starting another Notepad.exe.
The batch file does not control that.
You did not make the batch file owner for notepad.You transferred control to notepad and the batch finished, the batch file is closed after notepad opens.
Keep the batch open while notepad is running.

[Blisk]

Yes, you asked for one instance of batch and that is what  yu got.
Did you want something else?
If so, what?
You are starting another Notepad.exe.
The batch file does not control that.
You did not make the batch file owner for notepad.You transferred control to notepad and the batch finished, the batch file is closed after notepad opens.
Keep the batch open while notepad is running.

but it is not one instance of batch, when I run it second time it opens second notepad.
I just like to have a script which do the same as script I posted. I only want to choose in which folder lock file is.

[Geek-9pm]

but it is not one instance of batch, when I run it second time it opens second notepad.
I just like to have a script which do the same as script I posted. I only want to choose in which folder lock file is.

You are wrong.
The batch given by Salmon Trout  is one instance.
Pay attention to the detail.The batch must be the owner of the NOTEPAD invocation.
Your script gives control to Notepad.exe and becomes not an instance.
You must use the CALL testament.
Like this:

Code: [Select]

call notepad.exe
That works. 

[Blisk]

no it doesn't work
everytime I start batch it opens another notepad.exe and I used
call notepad.exe

[Geek-9pm]

On my system the batch file is one one instance. I can not even start another instance of it.
When your said  "only one instance of batch", what did you mean?
Will the batch file take control of another computer in another country? No.
Will the batch file become Lord and Master of the Windows Operating System? No.
Any batch file has a limited scope of control.
All the batch can do is prevent another instance of itself inside of its own dominion. The batch file itself is a child of CMD.EXE.

When I test this in Windows 7, I can not even get a commend prompt until Note Pad has closed.

I agree with Salmon Trout. You do not understand what  your are doing. You should learn a modern scripting language suitable to your needs. Python is a very good choice and currently there are many places where you can find tutorials.

I think you should read this:

Python – a Multiplatform Alternative to Bash/Batch Scripts?

The article is very good in making a point. Batch is not good for development of a powerful program that uses all of the features of your computer.

Instead of Python, you could learn to use Ruby. Or even VBA script.  Even javascript.
Batch is good for some scenarios. But it is a bad learning tool, unless you enjoy pain. 

EDIT: This is not just what I say. Look here:
The Five Best Programming Languages Worth Learning.

No matter whether you’re hoping to develop websites, software, games or a bit of everything, expanding your knowledge of different programming languages is essential in today’s ever-changing industry climate.

[Blisk]

thank you for your advice and ponting suggestion what I should start learn. I will do that, first I will go to take some powershell lessons.

About this script as I said before when I start batch file it opens notepad, when I double click again on batch file it opens another notepad and if I dobule click third time on batch file I get third notepad open.

Whole idea is to prevent starting batch file until first instance runs, but this script doesn't and one I posted it does but problem is lockfile path.

I will give you my computer to test it but I can't.
I have wind 10 professional and also tested on win 7 enterprise and on both is the same, no matter how many times I double click on batch file, everytime it opens notepad, so I can open as many as I want and that means script doesn't work.

[Salmon Trout]

@echo off
set lockfile=%~dpnx0.lock
echo Lockfile is %lockfile%
if exist "%lockfile%" (
   echo already running
   exit /b
) else (
   echo Lockfile not found
   echo Writing lockfile
   echo !date! !time! > "%lockfile%"
)
echo.
echo Rest of the batch file
echo.
echo Ready to delete lockfile
echo and exit batch file
pause
del "%lockfile%" && echo Lockfile deleted

[Salmon Trout]

Note: the lockfile can be anywhere you like, and named anything you want:

set lockfile=d:\locks\batchlock.xyz

Also note:

The echo statements in the batch, and the final pause command, are there so you can see how it works, and can be removed if you want.

[Blisk]

Thank you this works I changed
set lockfile=d:\locks\batchlock.lock

I also tried if lockfile can be generated from file name with this
set lockfile=d:\locks\%~dpnx0.lock
but that didn't work
%~dpnx0 is for full path variable

I will use first option.
thank you again.

[Salmon Trout]

I also tried if lockfile can be generated from file name with this
set lockfile=d:\locks\%~dpnx0.lock
but that didn't work
%~dpnx0 is for full path variable

Let's break down what %~dpnx0 means

%0 is is the batch file name and path, also, so is %~dpnx0

%~ and....
d is the drive letter (and colon) (
p is the path
n is the name
x is the extension

You can combine them

If your file is C:\Files\Sub\MyFile.bat

%~d0 expands to C:
%~p0 expands to \Files\Sub\
%~n0 expands to MyFile
%~x0 expands to .bat

So to make MyFile.lock you need %~n0.lock and you can put it in folder D:\whatever\somewhere\ with D:\whatever\somewhere\%~n0.lock

Reminder: don't make a batch variable called PATH, in upper or lower case, unless you really want to, and you know what you are doing. It will kill lots of batch functions.

[Blisk]

thank you.
you are a great man I learned alot from you.