help with looping

[valahrim]

i have a problem with batch file loop commands in MS dos  and need a little help.

below is a similar type of batch file i am currently using.

Code: [Select]

@echo off
:a
start
sleep 2
echo1
echo2
echo3
goto :a
echo end
 
i would like to terminate the loop created have the batch file continue so i can use multiple loop commands. is there a way i can do this.

thank you

[Sidewinder]

What condition has to be met to terminate the loop? Once you determine the condition, you can use an if statement in combination with a goto statement to branch out of the loop.

 

[valahrim]

the condition im after is to run thru the loop, say for ecample 5 times before it stops the loop and continues to run

[Dias de verano]

@echo off
set /a limit=5
set /a loops=0
:a
start
sleep 2
echo1
echo2
echo3
set /a loops=%loops%+1
if %loops% EQU %limit% goto end
goto :a
:end

[valahrim]

ok thx for that ill try it out, would u be able to explain the parts of the code?

[Carbon Dudeoxide]

set /a limit=5
set /a loops=0
Sets %limit% = 5 and %loops% = 0

set /a loops=%loops%+1
Adds 1 to %loops%. If this is the first loop, it would be 0+1.

if %loops% EQU %limit% goto end
If the number %loops% = 5 goto end.

This means in every loop, %loops% will add 1 to itself and when %loops% equals 5, it will terminate. If not, it goes to :a

[Carbon Dudeoxide]

I just notice you don't need to set limit=5

Code: [Select]

@echo off
set /a loops=0
:a
start
sleep 2
echo1
echo2
echo3
set /a loops=%loops%+1
if %loops% EQU 5 goto end
goto :a
:end
That should work.

[valahrim]

ok tyvm it all works fine. i no its not what i originally asked for but how does the call command work?

[Carbon Dudeoxide]

It calls another Batch File. For example:

You could do this with the call command

start.bat

Code: [Select]

@echo off
call settings.bat
echo %a% %b% %c%
pause
exit
settings.bat

Code: [Select]

set a=one
set b=two
set c=three
If the two files aren't in the same directory, you will need to use call C:\path\to\file.bat

[valahrim]

what is the echo %a% %b% %c% ued for? i see the relevance to the settings.bat but i dont understand why u need it and how you would run a command from it

[Carbon Dudeoxide]

That was an example.   

http://www.computerhope.com/call.htm

[valahrim]

woo it works ^^ awesum tyvm

[Carbon Dudeoxide]

 

[Dias de verano]

I just notice you don't need to set limit=5

Code: [Select]

if %loops% EQU 5 goto end

Thanks for worsening my code! 

Yes, I knew when I posted that you could hard-code the loop limit into the IF test, but that is what I was taught was sloppy programming practice, that is, code with "magic numbers" is deplored. Better to put it in a variable.

[valahrim]

well i kept the  set limit so its easier for me to find my way around the code