Batch not quite working right????

[Salmon Trout]

I am interested to see how you solve this.

[nameci]

I will let you know as soon as I do 

[nameci]

Hi Salmon Trout,

Thanks for all of your help, here is the solution to the problem 


@echo off
setlocal enableDelayedExpansion
cd /d C:\Users\jbrown\Desktop\Test
set I=2
:NextI
if /I %I% LEQ 999 set II=0%I%
if /I %I% LEQ 99 set II=00%I%
if /I %I% LEQ 9 set II=000%I%
if not exist "15-P!II!*" (       
    set /p "client_name=OPTIONAL Enter a client name and press <ENTER>:  "


    xcopy /s /e /i "15-P0000-Template" "15-P!II!!client_name!"

    goto :eof

)
set /a I+=1

if /i %I% LSS 999 goto NextI


ADDED THE ASTERISK

[Salmon Trout]

And what problem does the asterisk solve?

[nameci]

It bypasses the: set I=2 and recognizes the last number used each time the batch is run

[Salmon Trout]

It bypasses the: set I=2 and recognizes the last number used each time the batch is run

Are you sure?

[nameci]

Yup, it works perfectly now.  What are your thoughts?

[Salmon Trout]

Yup, it works perfectly now.  What are your thoughts?

Well done!

[nameci]

Thanks again for all of your help 

[Squashman]

I am more baffled as to why you are using the CASE INSENSITIVE switch with your IF command and you also do not need delayed expansion for the II variable.

And easier way to zero fill a number.

Code: [Select]

set II=000000000%I%
set II=%II:~-3%

[Salmon Trout]

And easier way to zero fill a number

Yes, definitely, and you can use different pad characters e.g. spaces if you want to make neat tables

[nameci]

I just started learning batch a few weeks ago.  So I started by looking at some examples here and there of existing batch files.  Your advice on how to do things better and easier is greatly appreciated. 

[Squashman]

I just started learning batch a few weeks ago.  So I started by looking at some examples here and there of existing batch files.  Your advice on how to do things better and easier is greatly appreciated. 

Since you are Zero filling your file names, they will basically always sort in perfect alpha numeric sequence in a batch file.  You could use a FOR command to get the file with the largest number and then strip the leading zeros and add 1 to it instead of incrementing a variable and checking if it doesn't exist.  If you get up to hundreds of files your code will be extremely slow.

[Salmon Trout]

Personally, I would store the next number in a file.

[nameci]

Thanks again for all of the advice.