What am i doing wrong?

[Arotin]

Hello,

here is my script (confidential info changed .. obviously):



setlocal enabledelayedexpansion
set Citpath=C:\Program Files (x86)\Citrix\ICA Client\SelfServicePlugin\CleanUp.exe

for /F %%F in (pclist.txt) do (

echo Connecting to %%F  ...
NET USE w: \\$$F\c$ PASSWORD /USER:Administrator
xcopy CitrixReceiver.exe w:
timeout /t 5
psexec \\%%F c:\CitrixReceiver.exe /silent /accepteula /STORE0="store;https://test.test.com/Citrix/pnagent/config.xml;on;TEST"
IF !errorlevel! EQU 0 psexec.exe \\%%F !Citpath! /CleanUser /silent
echo Complete
NET USE w: /delete
)

pause


- The problem i have having is, it would at first just close on its own, until i put that variable as the path, now it says "network connection could not be found"
i can ping the other machine, both on same network. is there anything wrong with my batch script here that im not seeing?



thanks in advance.

[Geek-9pm]

This is the right place to get help.
Myself, I can not do it because your code is too hard to read. It looks link you put a space in a place where is should not be.
Next time you put code in your post, please use  the CODE marker, the box with the # inside. That way  others can copy and test your code.

Also, make the code simple and modular. And include comments that explain what is going to happen. Also, provide a short set of input arguments (parameters) for testing. This lets  others test your code without damage to their own machines or network.

Best I can offer. But try again n and somebody else will see what your want.

[Squashman]

$$F should be %%F

[foxidrive]

is there anything wrong with my batch script here that im not seeing?

$$F should be %%F

Arotin, was this advice helpful to you?

[Arotin]

This is the right place to get help.
Myself, I can not do it because your code is too hard to read. It looks link you put a space in a place where is should not be.
Next time you put code in your post, please use  the CODE marker, the box with the # inside. That way  others can copy and test your code.

Also, make the code simple and modular. And include comments that explain what is going to happen. Also, provide a short set of input arguments (parameters) for testing. This lets  others test your code without damage to their own machines or network.

Best I can offer. But try again n and somebody else will see what your want.

Lol what? how is that hard to read....but thank you for the advice i will take it.

Arotin, was this advice helpful to you?

that was my typo on here, the code was correct.. that was not the issue. thank you..

[Squashman]

that was my typo on here, the code was correct.. that was not the issue. thank you..

Umm. Have you ever heard of copy and paste? Zero chance of error!

Repost all your code inside code tags, and maybe we can still help you. Use copy and paste this time.

[Arotin]

Umm. Have you ever heard of copy and paste? Zero chance of error!

Repost all your code inside code tags, and maybe we can still help you. Use copy and paste this time.

Will do in the future, i apologize for my typo. thanks. i ended up doing this manually one by one (installing receiver and configuring it). if i figure it out i will post the result here for all to see.


thanks.

[Squashman]

If you execute the NET USE command by itself from a cmd prompt does it successfully map the drive?
Also your CITPATH variable has spaces in it. You need to quote file paths that have spaces in them.

Also not understanding why you are mapping a drive letter to the administrative share and then using xcopy to copy the file over to the remote computer.  PSEXEC can do that all in one shot!  You never needed to map a drive letter to the remote computer.