Using a for loop to make unlimited folders

[BatchFileCommand]

This is my program which makes folders. The user just types in how many folders he wants to make and he can make that many.

Code: [Select]

@echo off
title Folder Maker
color 0a

cls
set /p folder=How many folders would you like to make:
for /l %%a in (1,1,%folder%) do (
cls
set /p foldername=What would you like to name folder #%%a:
mkdir "%foldername%"
set foldername=
)

msg * All folders created!

But this throws back an error message saying "The system could not find the enviroment option that was entered"  . Any way to fix this ?

[BC_Programmer]

QuickBasic, Freebasic, whatev.

Code: [Select]

Dim NumFolders as Long
Dim CurrFolder as String,I as long
Const FolderName="FOLDER"
numfolders=val(COMMAND$)
chDrive "C:"
chDir "\"
For I = 1 to numfolders
    mkDir CurrDIR$ + "FOLDER"
    chDir CURRDIR$ + "FOLDER"

next I



Sorry, couldn't resist 



where does it throw the error? Could you place trace echos in the batch?

[BatchFileCommand]

After I name the folder to make it throws the error message.

[computeruler]

And why would you need something like this?  More computer pranks?

[BC_Programmer]

maybe he wants to see how deep it will go?

[BatchFileCommand]

And why would you need something like this?  More computer pranks?

This is quite far from computer pranks. Think before you speak. This is so you don't have to spend
you time making a menu to ask how many folders you want to make.

[BC_Programmer]

And why would you need something like this?  More computer pranks?

This is quite far from computer pranks. Think before you speak. This is so you don't have to spend
you time making a menu to ask how many folders you want to make.

of which the practical applications are?

[BatchFileCommand]

of which the practical applications are?

I don't quite get what you mean there. But, back to the question. Is there a way to fix it so it won't throw out that error message and make the folders.

[GuruGary]

When you use environment variables that were set inside a FOR loop, you typically need to use the "setlocal enabledelayedexpansion" and then access them with ! instead of %.  Here is your script with those 2 changes:

Code: [Select]

@echo off
setlocal enabledelayedexpansion
title Folder Maker
color 0a

cls
set /p folder=How many folders would you like to make:
for /l %%a in (1,1,%folder%) do (
cls
set /p foldername=What would you like to name folder #%%a:
mkdir "!foldername!"
set foldername=
)

msg * All folders created!

[BatchFileCommand]

Thanks, that worked.

[computeruler]

BC ment why would you need to make all those folders

[BatchFileCommand]

It's not about how many folders I can make. It's that I don't want to make a big menu asking how many folders I want to make.

[BC_Programmer]

It's not about how many folders I can make. It's that I don't want to make a big menu asking how many folders I want to make.

why would you want a menu that asks you to create folders when it's far easier to do so using md and cd commands?

[computeruler]

And I still want to know why you need to make so many folders

[Dias de verano]

why would you want a menu that asks you to create folders when it's far easier to do so using md and cd commands?

Because beginning batch programmers love to create 150 line batch files with 56 labels that do the same thing as typing "DIR", maybe?